Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Severity Date to NVTs Details #2802

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Mar 18, 2021

What:

  • Add severity Date to NVTs details:

image

  • Will provide Tests in a seperate PR, for backporting.
  • Will fix parseDate in a seperate PR

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #2802 (a2c2a93) into gsa-21.04 (34466a4) will increase coverage by 0.14%.
The diff coverage is 98.18%.

❗ Current head a2c2a93 differs from pull request most recent head 1206203. Consider uploading reports for the commit 1206203 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2802      +/-   ##
=============================================
+ Coverage      53.71%   53.86%   +0.14%     
=============================================
  Files           1072     1075       +3     
  Lines          26223    26212      -11     
  Branches        7474     7477       +3     
=============================================
+ Hits           14086    14118      +32     
+ Misses         11019    10979      -40     
+ Partials        1118     1115       -3     
Impacted Files Coverage Δ
gsa/src/gmp/cancel.js 100.00% <ø> (ø)
gsa/src/gmp/capabilities/capabilities.js 100.00% <ø> (ø)
gsa/src/gmp/capabilities/everything.js 100.00% <ø> (ø)
gsa/src/gmp/collection/collectioncounts.js 82.60% <ø> (ø)
gsa/src/gmp/collection/parser.js 61.70% <ø> (ø)
gsa/src/gmp/command.js 100.00% <ø> (ø)
gsa/src/gmp/commands/alerts.js 14.28% <ø> (ø)
gsa/src/gmp/commands/audits.js 52.45% <ø> (ø)
gsa/src/gmp/commands/auth.js 100.00% <ø> (ø)
gsa/src/gmp/commands/certbund.js 63.63% <ø> (ø)
... and 267 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b8c62...1206203. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review March 18, 2021 12:35
@y0urself y0urself requested a review from a team March 18, 2021 12:35
gsa/src/gmp/models/nvt.js Outdated Show resolved Hide resolved
gsa/src/web/pages/nvts/details.js Outdated Show resolved Hide resolved
@y0urself y0urself merged commit 5d5dfda into greenbone:gsa-21.04 Mar 18, 2021
@swaterkamp swaterkamp added the port-to-main Use mergifiy to port PR to master label May 28, 2021
@swaterkamp swaterkamp removed the port-to-main Use mergifiy to port PR to master label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants