Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move error message and adjust design on login page #2780

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

swaterkamp
Copy link
Member

What:
Move error message and adjust design on login page
loginpage

Why:
To further unify the login page designs

How:
Visual inspection. Automatic tests are still passing.

Checklist:

@swaterkamp swaterkamp requested a review from sarahd93 March 9, 2021 14:07
@swaterkamp swaterkamp self-assigned this Mar 9, 2021
@swaterkamp swaterkamp requested a review from a team March 9, 2021 14:07
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #2780 (1168c37) into gsa-21.04 (34466a4) will increase coverage by 0.14%.
The diff coverage is 98.03%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2780      +/-   ##
=============================================
+ Coverage      53.71%   53.86%   +0.14%     
=============================================
  Files           1072     1075       +3     
  Lines          26223    26208      -15     
  Branches        7474     7476       +2     
=============================================
+ Hits           14086    14116      +30     
+ Misses         11019    10976      -43     
+ Partials        1118     1116       -2     
Impacted Files Coverage Δ
gsa/src/gmp/cancel.js 100.00% <ø> (ø)
gsa/src/gmp/capabilities/capabilities.js 100.00% <ø> (ø)
gsa/src/gmp/capabilities/everything.js 100.00% <ø> (ø)
gsa/src/gmp/collection/collectioncounts.js 82.60% <ø> (ø)
gsa/src/gmp/collection/parser.js 61.70% <ø> (ø)
gsa/src/gmp/command.js 100.00% <ø> (ø)
gsa/src/gmp/commands/alerts.js 14.28% <ø> (ø)
gsa/src/gmp/commands/audits.js 52.45% <ø> (ø)
gsa/src/gmp/commands/auth.js 100.00% <ø> (ø)
gsa/src/gmp/commands/certbund.js 63.63% <ø> (ø)
... and 261 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c07a3...1168c37. Read the comment docs.

@bjoernricks bjoernricks merged commit ca3e297 into greenbone:gsa-21.04 Mar 9, 2021
@swaterkamp swaterkamp deleted the loginErrorUpdate branch April 20, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants