-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the deprecated_by field to CPEs #2751
Conversation
cf7cd00
to
79f1b9c
Compare
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2751 +/- ##
=============================================
+ Coverage 53.71% 53.86% +0.14%
=============================================
Files 1072 1074 +2
Lines 26223 26210 -13
Branches 7474 7474
=============================================
+ Hits 14086 14117 +31
+ Misses 11019 10977 -42
+ Partials 1118 1116 -2
Continue to review full report at Codecov.
|
@@ -51,6 +51,12 @@ class Cpe extends Info { | |||
delete ret.update_time; | |||
} | |||
|
|||
if (isDefined(ret.raw_data) && isDefined(ret.raw_data['cpe-item'])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (isDefined(ret.raw_data) && isDefined(ret.raw_data['cpe-item'])) { | |
if (isDefined(ret?.raw_data['cpe-item'])) { |
gsa/src/web/pages/cpes/details.js
Outdated
@@ -36,7 +38,7 @@ import TableRow from 'web/components/table/row.js'; | |||
|
|||
import {Col} from 'web/entity/page'; | |||
|
|||
const CpeDetails = ({entity}) => { | |||
const CpeDetails = ({entity, links = true}) => { | |||
const {title, nvd_id, deprecated_by, updateTime, status, severity} = entity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const {title, nvd_id, deprecated_by, updateTime, status, severity} = entity; | |
const {title, nvd_id, deprecatedBy, updateTime, status, severity} = entity; |
342f709
to
759774d
Compare
@bjoernricks is it possible to use Mergify to backport this to master? |
Added the deprecated_by field to CPEs (bp #2751)
What:
Why:
details.js
. So I parsed the field in the model:How:
Checklist: