Update copyright and footer #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the copyright at visible places to current year 2021.
The abbreviation GVM means Greenbone Vulnerability Management.
Don't set a background color for the footer. The background should be defined by the parent component(s).
Currently the link used the default browser color. With this change the link is displayed in greenbone green if the user did visit our web page.
The copyright should be visible at the login page already.
Not sure how this got into the lock file but nevertheless use the correct version.
Updating the copyright year did break the footer test.
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2687 +/- ##
=============================================
+ Coverage 53.71% 53.86% +0.15%
=============================================
Files 1072 1073 +1
Lines 26223 26228 +5
Branches 7474 7468 -6
=============================================
+ Hits 14086 14129 +43
+ Misses 11019 10983 -36
+ Partials 1118 1116 -2
Continue to review full report at Codecov.
|
saberlynx
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Update footer, about page and login page
Why:
Update copyright to current year, add the footer already to the new login page, fix GVM wording, fix some styling at the footer.
How:
Visit GSA and check working and styling.
Checklist: