Stop toolbars from growing if they have only the help icon #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-20.08 #2641 +/- ##
=============================================
+ Coverage 53.06% 53.08% +0.01%
=============================================
Files 1072 1072
Lines 25900 25904 +4
Branches 7372 7399 +27
=============================================
+ Hits 13744 13751 +7
+ Misses 11034 11032 -2
+ Partials 1122 1121 -1
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Don't grow the toolbar on pages where there is only the help icon. This is achieved by simply wrapping it into a span.
Why:
The clickable area to link to the manual spread to 100% width of the screen. Other pages (e.g. tickets) already had a reduced click area, because their toolbar is wrapped already.
How:
Manually check whether the clickable areas are reduced to the icon on the 4 pages in question and if the links still work. Also updated the startpage test.
Checklist: