Fix selection for including related resources in permission dialog #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are in fact no related resources the initial value will not be an option in the Select anymore, but it's value will still be in its state. Ths results in a consoe warning and a useless label "1" in the textfield.
Codecov Report
@@ Coverage Diff @@
## gsa-20.08 #2632 +/- ##
=============================================
+ Coverage 52.76% 53.06% +0.30%
=============================================
Files 1070 1072 +2
Lines 25789 25900 +111
Branches 7312 7372 +60
=============================================
+ Hits 13607 13744 +137
+ Misses 11058 11034 -24
+ Partials 1124 1122 -2
Continue to review full report at Codecov.
|
saberlynx
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix initial value of dropdown for including related resources for permissions in MultiplePermissionsDialog
Why:
When the dropdown is initialized with "include related resources", but later there aren't any, the Select component will show a label- and useless value "1". Now we have "for current resource only" as standard if there are no related resources, and a "include related resources" if there are.
How:
Visual inspection of the options in the dropdown for entities with and without resources. Also the console doesn't throw a prop warning for Downshift anymore.
Checklist: