Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link from Hosts to TLS Certificates #2624

Merged
merged 4 commits into from
Dec 14, 2020

Conversation

swaterkamp
Copy link
Member

What:
Add an icon and filtered link from the host detailspage to a TLS certificates list with certs that have been found on this host. Use the "new" host_id= filter.

Why:
This was specified in the feature request for TLS Certificates as assets but was not implemented, yet, because the host_id= filter term didn't exist back then.

How:
Go to host detailspage, find new icon, click it and find yourself on a filtered TLS Certificate listpage.

Checklist:

@swaterkamp swaterkamp requested review from sarahd93 and a team December 11, 2020 16:52
@swaterkamp swaterkamp self-assigned this Dec 11, 2020
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #2624 (ded279b) into gsa-20.08 (073d2d2) will increase coverage by 0.30%.
The diff coverage is 74.26%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2624      +/-   ##
=============================================
+ Coverage      52.76%   53.06%   +0.30%     
=============================================
  Files           1070     1072       +2     
  Lines          25789    25900     +111     
  Branches        7312     7372      +60     
=============================================
+ Hits           13607    13744     +137     
+ Misses         11058    11034      -24     
+ Partials        1124     1122       -2     
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/gmp/models/tlscertificate.js 100.00% <ø> (ø)
gsa/src/web/components/error/errorpanel.js 100.00% <ø> (ø)
gsa/src/web/pages/alerts/condition.js 3.22% <0.00%> (ø)
gsa/src/web/pages/alerts/dialog.js 20.33% <0.00%> (ø)
.../web/pages/alerts/filtercountleastconditionpart.js 60.00% <ø> (ø)
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/detailspage.js 23.80% <ø> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f621d28...ded279b. Read the comment docs.

@swaterkamp swaterkamp merged commit df6db25 into greenbone:gsa-20.08 Dec 14, 2020
@swaterkamp swaterkamp deleted the TLSlinkFromHost branch December 14, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants