Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of severity level change alert condition #2623

Merged

Conversation

swaterkamp
Copy link
Member

What:
Show the correct direction of severity change in the condition column of alerts.

Why:
The logic behind selecting the correct value was incorrect. It was impossible to get "Severity level changed" and instead we always got "Severity level increased"

How:
I created 3 alerts, one for each condition, and visually checked whether the correct value was displayed. After editing those alerts the conditions were correctly updated. The alerts were created by sending the correct parameters to gvmd, so it was really just a displaying error.

Checklist:

@swaterkamp swaterkamp self-assigned this Dec 11, 2020
@swaterkamp swaterkamp requested a review from a team December 11, 2020 16:36
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #2623 (66a1f7b) into gsa-20.08 (073d2d2) will increase coverage by 0.30%.
The diff coverage is 74.26%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2623      +/-   ##
=============================================
+ Coverage      52.76%   53.06%   +0.30%     
=============================================
  Files           1070     1072       +2     
  Lines          25789    25900     +111     
  Branches        7312     7372      +60     
=============================================
+ Hits           13607    13744     +137     
+ Misses         11058    11034      -24     
+ Partials        1124     1122       -2     
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/gmp/models/tlscertificate.js 100.00% <ø> (ø)
gsa/src/web/components/error/errorpanel.js 100.00% <ø> (ø)
gsa/src/web/pages/alerts/condition.js 3.22% <0.00%> (ø)
gsa/src/web/pages/alerts/dialog.js 20.33% <0.00%> (ø)
.../web/pages/alerts/filtercountleastconditionpart.js 60.00% <ø> (ø)
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/detailspage.js 23.80% <ø> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7f20e...66a1f7b. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bjoernricks bjoernricks merged commit f621d28 into greenbone:gsa-20.08 Dec 12, 2020
@swaterkamp swaterkamp deleted the SeverityLevelAlertCondition branch April 20, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants