Fix display of severity level change alert condition #2623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Show the correct direction of severity change in the condition column of alerts.
Why:
The logic behind selecting the correct value was incorrect. It was impossible to get "Severity level changed" and instead we always got "Severity level increased"
How:
I created 3 alerts, one for each condition, and visually checked whether the correct value was displayed. After editing those alerts the conditions were correctly updated. The alerts were created by sending the correct parameters to gvmd, so it was really just a displaying error.
Checklist: