Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always send sort=name with delta report request filters #2570

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

swaterkamp
Copy link
Member

What:
Always send sort=name with delta report request filters.

Why:
To avoid confusion due to differing numbers of results and broken sort-reverse terms.

How:
Check whether the filter sent to gvmd always includes sort=name and never anything else or a sort-reverse term.

Checklist:

@swaterkamp swaterkamp requested review from sarahd93 and a team November 12, 2020 15:24
@swaterkamp swaterkamp self-assigned this Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #2570 (44a7580) into gsa-20.08 (073d2d2) will increase coverage by 0.29%.
The diff coverage is 75.43%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2570      +/-   ##
=============================================
+ Coverage      52.76%   53.05%   +0.29%     
=============================================
  Files           1070     1072       +2     
  Lines          25789    25900     +111     
  Branches        7312     7372      +60     
=============================================
+ Hits           13607    13741     +134     
+ Misses         11058    11037      -21     
+ Partials        1124     1122       -2     
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/gmp/models/tlscertificate.js 100.00% <ø> (ø)
gsa/src/web/components/error/errorpanel.js 100.00% <ø> (ø)
gsa/src/web/pages/alerts/dialog.js 20.33% <ø> (ø)
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/detailspage.js 23.80% <ø> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
gsa/src/web/pages/policies/detailspage.js 100.00% <ø> (ø)
gsa/src/web/pages/policies/row.js 100.00% <ø> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ae4ab...44a7580. Read the comment docs.

@sarahd93 sarahd93 merged commit be7b41b into greenbone:gsa-20.08 Nov 13, 2020
@swaterkamp swaterkamp deleted the DeltSorting branch April 20, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants