Update form fields #2520
Merged
Update form fields #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change values of fields must be controlled in the parent component. The uncontrolled use case isn't used at all and therefore completely unnecessary.
This fixes passing for example an error object instance as errorContent and displays the message of the error.
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2520 +/- ##
=============================================
+ Coverage 52.93% 53.07% +0.13%
=============================================
Files 1070 1071 +1
Lines 25811 25848 +37
Branches 7351 7350 -1
=============================================
+ Hits 13664 13719 +55
+ Misses 11030 11012 -18
Partials 1117 1117
Continue to review full report at Codecov.
|
saberlynx
reviewed
Oct 20, 2020
saberlynx
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Update form fields to fix a typo, a bug and to remove obsolete behavior.
Why:
Cleanup and fixing of form fields.
How:
All tests still run, linting is happy and verified that some form fields are still working manually.
Checklist: