Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to delete process without having had edges #2507

Merged
merged 3 commits into from
Oct 13, 2020

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Oct 13, 2020

What:
For a new process map it was not possible to delete a process without having had an edge created first. BPM crashed in that case. The crash now no longer happens.

Why:
To fix above mentioned bug

How:
Created a new user and go to BPM. Created a process and no edge. Deleted that process and saw BPM not crash.
An automated test was not written for this functionality, because it would only be possible to get an very indirect test at best.

Checklist:

@swaterkamp swaterkamp requested review from sarahd93 and a team October 13, 2020 07:57
@swaterkamp swaterkamp self-assigned this Oct 13, 2020
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #2507 into gsa-20.08 will increase coverage by 0.30%.
The diff coverage is 76.38%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2507      +/-   ##
=============================================
+ Coverage      52.76%   53.07%   +0.30%     
=============================================
  Files           1070     1072       +2     
  Lines          25789    25892     +103     
  Branches        7312     7397      +85     
=============================================
+ Hits           13607    13741     +134     
+ Misses         11058    11029      -29     
+ Partials        1124     1122       -2     
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/gmp/models/tlscertificate.js 100.00% <ø> (ø)
gsa/src/web/components/error/errorpanel.js 100.00% <ø> (ø)
gsa/src/web/pages/alerts/dialog.js 20.33% <ø> (ø)
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
gsa/src/web/pages/policies/detailspage.js 100.00% <ø> (ø)
gsa/src/web/pages/policies/row.js 100.00% <ø> (ø)
gsa/src/web/pages/portlists/detailspage.js 34.48% <ø> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24390ac...55e214b. Read the comment docs.

@sarahd93 sarahd93 merged commit 76ee110 into greenbone:gsa-20.08 Oct 13, 2020
@swaterkamp swaterkamp deleted the delProcWithNoEdge branch April 20, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants