-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop autofp #2480
Merged
Merged
Drop autofp #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2480 +/- ##
=============================================
- Coverage 52.93% 52.93% -0.01%
=============================================
Files 1070 1069 -1
Lines 25811 25807 -4
Branches 7351 7351
=============================================
- Hits 13664 13660 -4
Misses 11030 11030
Partials 1117 1117
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove the functionality "autofp" (Auto False Positives).
This is a filter functionality for scan results using CVEs of confirmed
applied vendor fixes to eliminate same CVE alerts from less reliable tests (like
remote banner tests).
Why:
The QoD is capable to filter our less reliable results where wanted.
This method shows a much better performance as well, and actually
is applied by default already with a value of 70%.
How:
The dialog element of the filter element "autofp" is removed as well as
any corresponding tests and handling.
Checklist: