Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop autofp #2480

Merged
merged 10 commits into from
Oct 1, 2020
Merged

Drop autofp #2480

merged 10 commits into from
Oct 1, 2020

Conversation

janowagner
Copy link
Member

@janowagner janowagner commented Sep 29, 2020

What:

Remove the functionality "autofp" (Auto False Positives).
This is a filter functionality for scan results using CVEs of confirmed
applied vendor fixes to eliminate same CVE alerts from less reliable tests (like
remote banner tests).

Why:

The QoD is capable to filter our less reliable results where wanted.
This method shows a much better performance as well, and actually
is applied by default already with a value of 70%.

How:

The dialog element of the filter element "autofp" is removed as well as
any corresponding tests and handling.

Checklist:

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #2480 into gsa-21.04 will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2480      +/-   ##
=============================================
- Coverage      52.93%   52.93%   -0.01%     
=============================================
  Files           1070     1069       -1     
  Lines          25811    25807       -4     
  Branches        7351     7351              
=============================================
- Hits           13664    13660       -4     
  Misses         11030    11030              
  Partials        1117     1117              
Impacted Files Coverage Δ
gsa/src/gmp/models/filter/convert.js 100.00% <ø> (ø)
gsa/src/gmp/models/filter/keywords.js 100.00% <ø> (ø)
...shboard/display/severity/severityclasstransform.js 18.64% <ø> (ø)
gsa/src/web/pages/nvts/dashboard/familydisplay.js 15.55% <ø> (ø)
gsa/src/web/pages/reports/detailsfilterdialog.js 18.18% <ø> (ø)
gsa/src/web/pages/results/filterdialog.js 37.50% <ø> (ø)
gsa/src/web/pages/tasks/dashboard/highresults.js 20.51% <ø> (ø)
...a/src/web/pages/tasks/dashboard/mosthighresults.js 50.00% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e053cc9...b6cb582. Read the comment docs.

@janowagner janowagner marked this pull request as ready for review September 29, 2020 11:13
@janowagner janowagner requested a review from a team September 29, 2020 11:13
@swaterkamp swaterkamp merged commit 55bd335 into greenbone:gsa-21.04 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants