Validate rows per page setting and fix tooltips #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-20.08 #2478 +/- ##
=============================================
+ Coverage 52.76% 53.07% +0.30%
=============================================
Files 1070 1072 +2
Lines 25789 25892 +103
Branches 7312 7396 +84
=============================================
+ Hits 13607 13741 +134
+ Misses 11058 11029 -29
+ Partials 1124 1122 -2
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Sep 29, 2020
Co-authored-by: Björn Ricks <[email protected]>
bjoernricks
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The "Rows Per Page" setting is restricted to use a value greater than 0, because 0 makes no sense in the first place and is showing at least 1 rows in the end. The new validation rule also prohibits an empty field at the same time.
Helping tooltips are now lazy translated because otherwise with the normal translation the error message was undefined.
Why:
Improve UX with helping tooltips and fix a bug
How:
Tooltips are now shown in the createProcessDialog and the rows per page setting in der userSettings dialog. The setting is invalid if the input is 0 or empty.
Checklist: