Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tooltip of override icon in result details #2467

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

saberlynx
Copy link
Contributor

What:

Change tooltip of override icon in result details.

Why:

Currently, the tooltip is "Overrides are applied.". This shows even on the result details, but that is misleading because we do not apply the new severity etc. on the result detailspage.

How:

Manual testing in web app.

Checklist:

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #2467 into gsa-20.08 will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2467      +/-   ##
=============================================
+ Coverage      52.76%   52.92%   +0.16%     
=============================================
  Files           1070     1070              
  Lines          25789    25829      +40     
  Branches        7312     7329      +17     
=============================================
+ Hits           13607    13671      +64     
+ Misses         11058    11039      -19     
+ Partials        1124     1119       -5     
Impacted Files Coverage Δ
gsa/src/gmp/commands/feedstatus.js 100.00% <ø> (ø)
gsa/src/gmp/commands/wizard.js 9.23% <ø> (ø)
gsa/src/gmp/gmpsettings.js 95.74% <ø> (ø)
gsa/src/gmp/models/alert.js 100.00% <ø> (ø)
gsa/src/gmp/models/event.js 22.91% <ø> (+2.17%) ⬆️
gsa/src/gmp/models/nvt.js 98.87% <ø> (ø)
gsa/src/gmp/models/ovaldef.js 94.64% <ø> (ø)
gsa/src/gmp/models/policy.js 100.00% <ø> (ø)
gsa/src/gmp/models/portlist.js 92.59% <ø> (+0.28%) ⬆️
gsa/src/gmp/models/report/parser.js 97.85% <ø> (+0.38%) ⬆️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3596949...00c3c5d. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review September 23, 2020 14:35
@saberlynx saberlynx requested review from a team and sarahd93 September 23, 2020 14:35
@saberlynx saberlynx merged commit ff335c6 into greenbone:gsa-20.08 Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants