Edit dialog: only send name and comment if config or policy is in use, and add in use notification

CHANGELOG.md

@@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### Changed
 - Change tooltip of override icon in result details [#2467](https://github.com/greenbone/gsa/pull/2467)
+- For edit config/policy dialog, only send name and comment if config or policy is in use, and add in use notification [#2463](https://github.com/greenbone/gsa/pull/2463)
 - Changed visual appearance of compliance status bar [#2457](https://github.com/greenbone/gsa/pull/2457)
 - Changed delete icons on report format detailspage and schedule detailspage to trashcan icons [#2459](https://github.com/greenbone/gsa/pull/2459)
 - Use <predefined> to disable feed object editing and filter creation on feed status page [#2398](https://github.com/greenbone/gsa/pull/2398)

gsa/public/locales/gsa-de.json

@@ -632,8 +632,6 @@
   "Export Policy as XML": "Richtlinie als XML exportieren",
   "Export Port List": "Portliste exportieren",
   "Export PortList as XML": "Portliste als XML exportieren",
-  "Export Report Format": "Berichtformat exportieren",
-  "Export Report Format as XML": "Berichtformat als XML exportieren",
   "Export Result as XML": "Ergebnis als XML exportieren",
   "Export Role": "Rolle exportieren",
   "Export Role as XML": "Rolle als XML exportieren",
@@ -1658,9 +1656,11 @@
   "The last {{weekday}} every {{interval}} months": "Jeden letzten {{weekday}} jeden {{interval}}. Monat",
   "The maximum of {{num}} hosts was exceeded. If there are more hosts associated with this process, they will not be taken into account.": "Das Maximum von {{num}} Hosts wurde überschritten. Sollten weitere Hosts mit diesem Prozess verknüpft sein, werden sie nicht mitberücksichtigt.",
   "The name must include at least one alphanumeric character or one of .,-/_# and space.": "Der Name muss mindestens ein alphanumerisches Zeichen oder eines von .,-/_# und Leerzeichen enthalten.",
+  "The policy is currently in use by one or more audits, therefore only name and comment can be modified.": "Die Richtlinie wird im Moment von Audits verwendet, daher können nur Name und Kommentar bearbeitet werden.",
   "The port range needs numerical values for start and end!": "Der Portbereich benötigt numerische Werte für Start und Ende!",
   "The report cannot be displayed because no Greenbone Vulnerability Manager report format is available. This could be due to a missing gvmd data feed. Please update the gvmd data feed, check the \"feed import owner\" setting, or contact your system administrator.": "Der Bericht kann nicht angezeigt werden, weil dem Greenbone Vulnerability Manager kein Berichtformat zur Verfügung steht. Dies könnte an einem fehlenden gvmd Data Feed liegen. Bitte aktualisieren Sie den gvmd Data Feed, überprüfen die \"Feed Import Besitzer\"-Einstellungen, oder kontaktieren Ihren Systemadministrator.",
   "The report is empty. The filter does not match any of the {{all}} results.": "Der Bericht ist leer. Der Filter passt zu keinem der {{all}} Ergebnisse.",
+  "The scan config is currently in use by one or more tasks, therefore only name and comment can be modified.": "Die Scan-Konfiguration wird im Moment von Aufgaben verwendet, daher können nur Name und Kommentar bearbeitet werden.",
   "The scan did not collect any results": "Der Scan hat keine Ergebnisse gesammelt",
   "The scan is still running and no results have arrived yet": "Der Scan läuft noch und es sind noch keine Ergebnisse eingetroffen",
   "The scan just started and no results have arrived yet": "Der Scan hat gerade begonnen und es sind noch keine Ergebnisse eingetroffen",

gsa/src/gmp/commands/__tests__/policy.js

@@ -110,6 +110,35 @@ describe('PolicyCommand tests', () => {
       });
   });
 
+  test('should save an in use policy with undefined input objects', () => {
+    const response = createActionResultResponse();
+    const fakeHttp = createHttp(response);
+
+    expect.hasAssertions();
+
+    const cmd = new PolicyCommand(fakeHttp);
+    return cmd
+      .save({
+        id: 'c1',
+        name: 'foo',
+        comment: 'somecomment',
+        trend: undefined,
+        select: undefined,
+        scannerPreferenceValues: undefined,
+        scannerId: undefined,
+      })
+      .then(() => {
+        expect(fakeHttp.request).toHaveBeenCalledWith('post', {
+          data: {
+            cmd: 'save_config',
+            comment: 'somecomment',
+            config_id: 'c1',
+            name: 'foo',
+          },
+        });
+      });
+  });
+
   test('should return single policy', () => {
     const response = createEntityResponse('config', {_id: 'foo'});
     const fakeHttp = createHttp(response);

gsa/src/gmp/commands/__tests__/scanconfig.js

@@ -184,6 +184,35 @@ describe('ScanConfigCommand tests', () => {
       });
   });
 
+  test('should save an in use config with undefined input objects', () => {
+    const response = createActionResultResponse();
+    const fakeHttp = createHttp(response);
+
+    expect.hasAssertions();
+
+    const cmd = new ScanConfigCommand(fakeHttp);
+    return cmd
+      .save({
+        id: 'c1',
+        name: 'foo',
+        comment: 'somecomment',
+        trend: undefined,
+        select: undefined,
+        scannerPreferenceValues: undefined,
+        scannerId: undefined,
+      })
+      .then(() => {
+        expect(fakeHttp.request).toHaveBeenCalledWith('post', {
+          data: {
+            cmd: 'save_config',
+            comment: 'somecomment',
+            config_id: 'c1',
+            name: 'foo',
+          },
+        });
+      });
+  });
+
   test('should save a config family', () => {
     const response = createActionResultResponse();
     const fakeHttp = createHttp(response);

gsa/src/gmp/commands/policies.js

@@ -61,14 +61,18 @@ export class PolicyCommand extends EntityCommand {
   }
 
   save({id, name, comment = '', trend, select, scannerPreferenceValues}) {
+    const trendData = isDefined(trend) ? convert(trend, 'trend:') : {};
+    const scannerPreferenceData = isDefined(scannerPreferenceValues)
+      ? convert(scannerPreferenceValues, 'preference:scanner:scanner:scanner:')
+      : {};
+
+    const selectData = isDefined(select)
+      ? convertSelect(select, 'select:')
+      : {};
     const data = {
-      ...convert(trend, 'trend:'),
-      ...convert(
-        scannerPreferenceValues,
-        'preference:scanner:scanner:scanner:',
-      ),
-      ...convertSelect(select, 'select:'),
-
+      ...trendData,
+      ...scannerPreferenceData,
+      ...selectData,
       cmd: 'save_config',
       id,
       comment,

gsa/src/gmp/commands/scanconfigs.js

@@ -104,14 +104,18 @@ export class ScanConfigCommand extends EntityCommand {
     scannerId,
     scannerPreferenceValues,
   }) {
+    const trendData = isDefined(trend) ? convert(trend, 'trend:') : {};
+    const scannerPreferenceData = isDefined(scannerPreferenceValues)
+      ? convert(scannerPreferenceValues, 'preference:scanner:scanner:scanner:')
+      : {};
+
+    const selectData = isDefined(select)
+      ? convertSelect(select, 'select:')
+      : {};
     const data = {
-      ...convert(trend, 'trend:'),
-      ...convert(
-        scannerPreferenceValues,
-        'preference:scanner:scanner:scanner:',
-      ),
-      ...convertSelect(select, 'select:'),
-
+      ...trendData,
+      ...scannerPreferenceData,
+      ...selectData,
       cmd: 'save_config',
       id,
       comment,

gsa/src/web/components/dialog/dialoginlinenotification.js

@@ -0,0 +1,28 @@
+/* Copyright (C) 2020 Greenbone Networks GmbH
+ *
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Affero General Public License
+ * as published by the Free Software Foundation, either version 3
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import styled from 'styled-components';
+
+const DialogInlineNotification = styled.div`
+  font-size: 14px;
+  margin-bottom: 0px;
+  display: flex;
+  justify-content: center;
+`;
+
+export default DialogInlineNotification;

gsa/src/web/pages/policies/component.js

@@ -135,6 +135,7 @@ class PolicyComponent extends React.Component {
 
     this.handleChange = this.handleChange.bind(this);
     this.handleScannerChange = this.handleScannerChange.bind(this);
+    this.handleSavePolicy = this.handleSavePolicy.bind(this);
   }
 
   handleChange(value, name) {
@@ -192,6 +193,20 @@ class PolicyComponent extends React.Component {
     this.handleInteraction();
   }
 
+  handleSavePolicy(d) {
+    const {gmp} = this.props;
+    const {policy} = this.state;
+
+    this.handleInteraction();
+    const {name, comment, id} = d;
+    let saveData = d;
+    if (policy.isInUse()) {
+      saveData = {name, comment, id};
+    }
+
+    return gmp.policy.save(saveData).then(() => this.closeEditPolicyDialog());
+  }
+
   openCreatePolicyDialog() {
     this.loadScanners();
 
@@ -761,13 +776,11 @@ class PolicyComponent extends React.Component {
                   scannerPreferences={policy.preferences.scanner}
                   scanners={scanners}
                   title={title}
+                  usageType={'policy'}
                   onClose={this.handleCloseEditPolicyDialog}
                   onEditConfigFamilyClick={this.openEditPolicyFamilyDialog}
                   onEditNvtDetailsClick={this.openEditNvtDetailsDialog}
-                  onSave={d => {
-                    this.handleInteraction();
-                    return save(d).then(() => this.closeEditPolicyDialog());
-                  }}
+                  onSave={this.handleSavePolicy}
                 />
               )}
             </React.Fragment>