Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use trash icons instead of delete icons for report formats and schedules #2459

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

sarahd93
Copy link
Contributor

What:

Change delete icons on report format detailspage and schedule detailspage to trashcan icons.

Why:

The report format detailspage and the schedule detailspage misleadingly show delete icons when it should be trashcan icons instead. Clicking on the icon moves the entities to the trashcan.

How:

Checklist:

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2459 into gsa-20.08 will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2459      +/-   ##
=============================================
+ Coverage      52.76%   52.93%   +0.16%     
=============================================
  Files           1070     1070              
  Lines          25789    25831      +42     
  Branches        7312     7358      +46     
=============================================
+ Hits           13607    13673      +66     
+ Misses         11058    11039      -19     
+ Partials        1124     1119       -5     
Impacted Files Coverage Δ
gsa/src/gmp/commands/feedstatus.js 100.00% <ø> (ø)
gsa/src/gmp/commands/wizard.js 9.23% <ø> (ø)
gsa/src/gmp/gmpsettings.js 95.74% <ø> (ø)
gsa/src/gmp/models/alert.js 100.00% <ø> (ø)
gsa/src/gmp/models/event.js 22.91% <ø> (+2.17%) ⬆️
gsa/src/gmp/models/nvt.js 98.87% <ø> (ø)
gsa/src/gmp/models/ovaldef.js 94.64% <ø> (ø)
gsa/src/gmp/models/policy.js 100.00% <ø> (ø)
gsa/src/gmp/models/portlist.js 92.59% <ø> (+0.28%) ⬆️
gsa/src/gmp/models/report/parser.js 97.85% <ø> (+0.38%) ⬆️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26e061...bd61b7b. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review September 18, 2020 06:40
@sarahd93 sarahd93 requested review from a team, saberlynx and swaterkamp September 18, 2020 06:40
@swaterkamp swaterkamp merged commit eb5b320 into greenbone:gsa-20.08 Sep 18, 2020
@sarahd93 sarahd93 deleted the trash_icons_20.08 branch September 18, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants