Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visual appearance of compliance status bar #2457

Merged
merged 5 commits into from
Sep 18, 2020

Conversation

sarahd93
Copy link
Contributor

What:

Change compliance status bar to always show the ratio of compliant and none compliant results in red and green.

Why:

Before, we used different colors for the bar for low, medium and high compliance. A compliance of 0% would just have a dark background since there were no compliant results. This made it seem as if 0% was not as bad as a low percentage which would be shown in red.

How:

Checklist:

Example of the new compliance status bar:
new_compliance_status

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #2457 into gsa-20.08 will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2457      +/-   ##
=============================================
+ Coverage      52.76%   52.92%   +0.16%     
=============================================
  Files           1070     1070              
  Lines          25789    25829      +40     
  Branches        7312     7356      +44     
=============================================
+ Hits           13607    13671      +64     
+ Misses         11058    11039      -19     
+ Partials        1124     1119       -5     
Impacted Files Coverage Δ
gsa/src/gmp/commands/feedstatus.js 100.00% <ø> (ø)
gsa/src/gmp/commands/wizard.js 9.23% <ø> (ø)
gsa/src/gmp/gmpsettings.js 95.74% <ø> (ø)
gsa/src/gmp/models/alert.js 100.00% <ø> (ø)
gsa/src/gmp/models/event.js 22.91% <ø> (+2.17%) ⬆️
gsa/src/gmp/models/nvt.js 98.87% <ø> (ø)
gsa/src/gmp/models/ovaldef.js 94.64% <ø> (ø)
gsa/src/gmp/models/policy.js 100.00% <ø> (ø)
gsa/src/gmp/models/portlist.js 92.59% <ø> (+0.28%) ⬆️
gsa/src/gmp/models/report/parser.js 97.85% <ø> (+0.38%) ⬆️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5b320...78a0502. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review September 18, 2020 09:03
@sarahd93 sarahd93 requested review from a team, saberlynx and swaterkamp September 18, 2020 09:03
@swaterkamp swaterkamp merged commit 3596949 into greenbone:gsa-20.08 Sep 18, 2020
@sarahd93 sarahd93 deleted the compliance_bar_color_20.08 branch September 18, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants