Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove severity class 'bsi' #2445

Merged
merged 3 commits into from
Sep 7, 2020

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Sep 7, 2020

What:

Remove the severity class 'bsi'

Why:

These classes are identical with the classes of 'nist'.

How:

Checklist:

These classes are identical with type 'nist' anyway.
@mattmundell mattmundell requested review from a team and janowagner September 7, 2020 09:28
CHANGELOG.md Outdated
- Removed Internet Explorer 11 support [#2399](https://github.com/greenbone/gsa/pull/2399)
- Removed parsing and testing of textExcerpt [#2316](https://github.com/greenbone/gsa/pull/2316)
- Removed extra parsing of comment and summary in Model [#2309](https://github.com/greenbone/gsa/pull/2309)
- Removed severity class 'bsi' [#2434](https://github.com/greenbone/gsa/pull/2434)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are adding new entries to the top of the list in the changelog. Could you move the current entry accordingly, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@swaterkamp swaterkamp self-requested a review September 7, 2020 09:52
@swaterkamp swaterkamp merged commit 981f74c into greenbone:gsa-21.04 Sep 7, 2020
@swaterkamp swaterkamp mentioned this pull request Sep 7, 2020
2 tasks
@mattmundell mattmundell deleted the reduce-severity-classes branch September 7, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants