-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create alerts via graphql #2425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2425 +/- ##
==========================================
+ Coverage 54.95% 55.21% +0.26%
==========================================
Files 1094 1095 +1
Lines 26573 26734 +161
Branches 7538 7642 +104
==========================================
+ Hits 14603 14762 +159
- Misses 10862 10865 +3
+ Partials 1108 1107 -1
Continue to review full report at Codecov.
|
bd637f8
to
e830a9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole conversion seems to be unnecessary to me. Why not unify the API and frontend? The frontend should just use the values that the backend expects. And you are free to adjust the backend for the frontend needs.
composer_include_notes: 1, | ||
composer_include_overrides: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be send via the api. At least not as methodData. We need to think about the api changes for the content composer sometime in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am really not satisfied with the alert handling and the API but we leave it as it is atm.
What:
Implement a
handleSaveAlert
method using thecreateAlert
mutation then refetch alerts after creating the alert.Why:
It is possible to create alerts from the task dialog.
How:
Checklist: