Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing oval def subsections #2396

Merged

Conversation

sarahd93
Copy link
Contributor

On the oval def details page the sub sections were all empty because of a parsing error in the oval def model.

(The error was similar to the one that caused #2388)

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review August 18, 2020 14:54
@sarahd93 sarahd93 requested a review from a team August 18, 2020 14:54
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #2396 into gsa-20.08 will increase coverage by 0.17%.
The diff coverage is 82.57%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2396      +/-   ##
=============================================
+ Coverage      52.76%   52.93%   +0.17%     
=============================================
  Files           1070     1070              
  Lines          25789    25835      +46     
  Branches        7312     7332      +20     
=============================================
+ Hits           13607    13677      +70     
+ Misses         11058    11039      -19     
+ Partials        1124     1119       -5     
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/web/components/error/errorpanel.js 100.00% <ø> (ø)
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
gsa/src/web/pages/policies/detailspage.js 100.00% <ø> (ø)
gsa/src/web/pages/policies/row.js 100.00% <ø> (ø)
gsa/src/web/pages/portlists/detailspage.js 34.48% <ø> (ø)
gsa/src/web/pages/portlists/row.js 55.55% <ø> (ø)
gsa/src/web/pages/reportformats/detailspage.js 33.33% <ø> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a5681...186608d. Read the comment docs.

@bjoernricks bjoernricks merged commit a07de2c into greenbone:gsa-20.08 Aug 18, 2020
@sarahd93 sarahd93 deleted the oval_def_sections_empty_20.08 branch August 19, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants