Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor textual improvement to explain which feed should be synced. #2371

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Minor textual improvement to explain which feed should be synced. #2371

merged 2 commits into from
Aug 7, 2020

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Aug 7, 2020

Minor update for #2367 with the background that just mentioning "feed" might make a user to think that e.g. the NVT feed should be synced or similar.

I've also made the .js text more consistent concerning the used spaces because a few text parts had trailing spaces where the others had leading spaces.

Checklist:

@cfi-gb cfi-gb requested a review from a team August 7, 2020 08:59
swaterkamp
swaterkamp previously approved these changes Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #2371 into gsa-20.08 will increase coverage by 0.15%.
The diff coverage is 81.60%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2371      +/-   ##
=============================================
+ Coverage      52.76%   52.92%   +0.15%     
=============================================
  Files           1070     1070              
  Lines          25789    25835      +46     
  Branches        7312     7359      +47     
=============================================
+ Hits           13607    13672      +65     
+ Misses         11058    11044      -14     
+ Partials        1124     1119       -5     
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/web/components/error/errorpanel.js 100.00% <ø> (ø)
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
gsa/src/web/pages/policies/detailspage.js 100.00% <ø> (ø)
gsa/src/web/pages/policies/row.js 100.00% <ø> (ø)
gsa/src/web/pages/portlists/detailspage.js 34.48% <ø> (ø)
gsa/src/web/pages/portlists/row.js 55.55% <ø> (ø)
gsa/src/web/pages/reportformats/detailspage.js 33.33% <ø> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 264460b...33fb63f. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All deamon and command names should be in lower case (openvas, gvmd, gsad, gvm-cli, ...).

gsa/public/locales/gsa-de.json Outdated Show resolved Hide resolved
gsa/src/web/pages/reports/detailspage.js Outdated Show resolved Hide resolved
@bjoernricks bjoernricks merged commit c26b670 into greenbone:gsa-20.08 Aug 7, 2020
@cfi-gb cfi-gb deleted the minor_text_improvement branch August 7, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants