Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix disappearing scanned hosts #2357

Merged

Conversation

sarahd93
Copy link
Contributor

@sarahd93 sarahd93 commented Aug 3, 2020

The "Hosts scanned" row in the report details was disappearing every time the page was reloading. Store count for scanned hosts in state to be able to display it the whole time.

Checklist:

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #2357 into gsa-20.08 will increase coverage by 0.14%.
The diff coverage is 89.70%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2357      +/-   ##
=============================================
+ Coverage      52.76%   52.91%   +0.14%     
=============================================
  Files           1070     1070              
  Lines          25789    25809      +20     
  Branches        7312     7320       +8     
=============================================
+ Hits           13607    13656      +49     
+ Misses         11058    11035      -23     
+ Partials        1124     1118       -6     
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
gsa/src/web/pages/policies/detailspage.js 100.00% <ø> (ø)
gsa/src/web/pages/policies/row.js 100.00% <ø> (ø)
gsa/src/web/pages/portlists/detailspage.js 34.48% <ø> (ø)
gsa/src/web/pages/portlists/row.js 55.55% <ø> (ø)
gsa/src/web/pages/reportformats/detailspage.js 33.33% <ø> (ø)
gsa/src/web/pages/reportformats/row.js 40.00% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a678a...60bd695. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review August 3, 2020 11:29
@sarahd93 sarahd93 requested review from a team, bjoernricks and saberlynx August 3, 2020 11:29
@bjoernricks bjoernricks merged commit 152c361 into greenbone:gsa-20.08 Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants