Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reload timer to feedstatuspage and displaying when updating is in progress #2350

Merged
merged 12 commits into from
Jul 31, 2020

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Jul 29, 2020

Checklist:

@saberlynx saberlynx changed the title Reload feed Add reload timer to feedstatuspage and displaying when updating is in progress Jul 29, 2020
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #2350 into gsa-20.08 will increase coverage by 0.14%.
The diff coverage is 88.70%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2350      +/-   ##
=============================================
+ Coverage      52.76%   52.90%   +0.14%     
=============================================
  Files           1070     1070              
  Lines          25789    25806      +17     
  Branches        7312     7320       +8     
=============================================
+ Hits           13607    13653      +46     
+ Misses         11058    11035      -23     
+ Partials        1124     1118       -6     
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
gsa/src/web/pages/policies/detailspage.js 100.00% <ø> (ø)
gsa/src/web/pages/policies/row.js 100.00% <ø> (ø)
gsa/src/web/pages/portlists/detailspage.js 34.48% <ø> (ø)
gsa/src/web/pages/portlists/row.js 55.55% <ø> (ø)
gsa/src/web/pages/reportformats/detailspage.js 33.33% <ø> (ø)
gsa/src/web/pages/reportformats/row.js 40.00% <ø> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb1aa81...79d8891. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review July 29, 2020 12:34
@saberlynx saberlynx requested a review from a team July 29, 2020 12:34
@saberlynx saberlynx requested a review from sarahd93 July 29, 2020 12:39
gsa/src/web/pages/extras/feedstatuspage.js Outdated Show resolved Hide resolved
gsa/src/web/pages/extras/feedstatuspage.js Outdated Show resolved Hide resolved
@saberlynx saberlynx requested a review from sarahd93 July 29, 2020 14:18
@sarahd93 sarahd93 merged commit 89849b9 into greenbone:gsa-20.08 Jul 31, 2020
@@ -30,6 +30,7 @@ describe('FeedStatusCommand tests', () => {
name: 'foo',
version: 201906251319,
description: 'bar',
currently_syncing: {timestamp: 'baz'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been a camel case variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants