Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Modify Task Wizard #2340

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Conversation

sarahd93
Copy link
Contributor

The radio buttons in the Modify Task Wizard were not working due to a missing convert function.

Also the calculated date of the schedule was wrong since day() returns the day of the week and not the day of the month. Use date() instead. (See also https://momentjs.com/docs/#/get-set/date/)

Checklist:

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #2340 into gsa-9.0 will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-9.0    #2340      +/-   ##
===========================================
+ Coverage    50.25%   50.26%   +0.01%     
===========================================
  Files         1070     1070              
  Lines        25159    25163       +4     
  Branches      7117     7119       +2     
===========================================
+ Hits         12644    12649       +5     
+ Misses       11370    11369       -1     
  Partials      1145     1145              
Impacted Files Coverage Δ
gsa/src/gmp/commands/wizard.js 9.23% <0.00%> (ø)
gsa/src/web/pages/schedules/details.js 12.50% <ø> (ø)
gsa/src/web/wizard/modifytaskwizard.js 20.00% <ø> (ø)
gsa/src/gmp/models/event.js 22.91% <100.00%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417fcec...6fc9b09. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review July 24, 2020 14:02
@sarahd93 sarahd93 requested review from a team and saberlynx July 24, 2020 14:02
@sarahd93 sarahd93 merged commit b3b840d into greenbone:gsa-9.0 Jul 27, 2020
@sarahd93 sarahd93 deleted the modify_task_wizard_gsa9 branch July 27, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants