Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same counts in EmptyResultsReport as the TabTitle #2335

Merged
merged 3 commits into from
Jul 23, 2020

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Jul 23, 2020

Our ResultsTab fetches a different CollectionCounts from store to use with the EmptyResultsReport and this causes a significantly different number to be displayed in the EmptyResultsReport when the user filters for a nonexistent result from what is shown on the Results TabTitle component. They should use the same props and be consistent.

Checklist:

… so the empty results report will use the same numbers
@saberlynx saberlynx requested review from a team and sarahd93 July 23, 2020 08:53
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #2335 into gsa-20.08 will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2335      +/-   ##
=============================================
+ Coverage      52.76%   52.77%   +0.01%     
=============================================
  Files           1070     1070              
  Lines          25789    25786       -3     
  Branches        7312     7336      +24     
=============================================
+ Hits           13607    13609       +2     
+ Misses         11058    11056       -2     
+ Partials        1124     1121       -3     
Impacted Files Coverage Δ
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
gsa/src/web/pages/reports/details/resultstab.js 8.26% <ø> (ø)
gsa/src/web/pages/reports/detailscontent.js 59.03% <ø> (ø)
gsa/src/web/pages/reports/row.js 14.81% <ø> (ø)
gsa/src/web/pages/tasks/component.js 30.07% <0.00%> (+0.57%) ⬆️
gsa/src/web/routes.js 83.33% <ø> (ø)
gsa/src/gmp/models/alert.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c63ee...1cc25a7. Read the comment docs.

@swaterkamp swaterkamp merged commit 8b27e5a into greenbone:gsa-20.08 Jul 23, 2020
@saberlynx saberlynx deleted the filter-message-2 branch July 31, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants