Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken radio buttons in alert dialog #2326

Merged
merged 3 commits into from
Jul 20, 2020

Conversation

sarahd93
Copy link
Contributor

The radio buttons for email alerts in the alert dialog were not working. The corresponding value from the model was a number but the dialog was expecting a string.

Fix parsing in the alert model to return a string as expected.

Checklist:

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #2326 into gsa-20.08 will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2326      +/-   ##
=============================================
- Coverage      52.76%   52.75%   -0.01%     
=============================================
  Files           1070     1070              
  Lines          25789    25791       +2     
  Branches        7312     7313       +1     
=============================================
- Hits           13607    13606       -1     
- Misses         11058    11061       +3     
  Partials        1124     1124              
Impacted Files Coverage Δ
gsa/src/web/pages/cpes/details.js 11.11% <ø> (ø)
gsa/src/web/pages/extras/trashactions.js 5.49% <0.00%> (ø)
gsa/src/web/pages/hosts/dialog.js 50.00% <ø> (ø)
gsa/src/web/pages/reports/row.js 14.81% <ø> (ø)
gsa/src/web/routes.js 83.33% <ø> (ø)
gsa/src/gmp/models/alert.js 100.00% <100.00%> (ø)
gsa/src/web/entities/container.js 44.48% <0.00%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c005957...5fa5de0. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review July 17, 2020 12:34
@sarahd93 sarahd93 requested review from a team, saberlynx and swaterkamp July 17, 2020 12:34
@swaterkamp swaterkamp merged commit f936cd1 into greenbone:gsa-20.08 Jul 20, 2020
@sarahd93 sarahd93 deleted the alert_radio_buttons_20.08 branch July 20, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants