Adjust parsing in cve model #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-9.0 #2294 +/- ##
===========================================
+ Coverage 47.36% 50.25% +2.89%
===========================================
Files 1045 1070 +25
Lines 24129 25159 +1030
Branches 6745 7143 +398
===========================================
+ Hits 11428 12644 +1216
+ Misses 11560 11370 -190
- Partials 1141 1145 +4
Continue to review full report at Codecov.
|
swaterkamp
reviewed
Jul 3, 2020
| ret.publishedTime = parseDate(entry['published-datetime'].__text); | ||
| ret.lastModifiedTime = parseDate(entry['last-modified-datetime'].__text); | ||
| ret.publishedTime = parseDate(entry['published-datetime']); | ||
| ret.lastModifiedTime = parseDate(entry['last-modified-datetime']); | ||
|
|
||
| ret.references = map(entry.references, ref => ({ | ||
| name: ref.reference.__text, |
There was a problem hiding this comment.
This is still working with __text and ret.source is not?
There was a problem hiding this comment.
The problem is not that __text is not working anymore. The difference is having <foo>text</foo> and <foo id=123>text</foo> or <foo>text <bar /></foo>. For the first one __text does not work anymore but for the other two it does work and is actually needed.
bjoernricks
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing in cve model.
This fixes
It also removes the cwe id as this has not been displayed starting with GOS 5 and seems not to be needed anymore.
Checklist: