Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with duplicate settings in dashboard getSetting() #2290

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp requested review from sarahd93 and a team July 2, 2020 09:56
@swaterkamp swaterkamp self-assigned this Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #2290 into gsa-9.0 will increase coverage by 2.89%.
The diff coverage is 88.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-9.0    #2290      +/-   ##
===========================================
+ Coverage    47.36%   50.25%   +2.89%     
===========================================
  Files         1045     1070      +25     
  Lines        24129    25162    +1033     
  Branches      6745     7143     +398     
===========================================
+ Hits         11428    12645    +1217     
+ Misses       11560    11373     -187     
- Partials      1141     1144       +3     
Impacted Files Coverage Δ
gsa/src/gmp/cancel.js 100.00% <ø> (ø)
gsa/src/gmp/capabilities/capabilities.js 100.00% <ø> (ø)
gsa/src/gmp/capabilities/everything.js 100.00% <ø> (ø)
gsa/src/gmp/collection/collectioncounts.js 82.60% <ø> (+30.43%) ⬆️
gsa/src/gmp/command.js 100.00% <ø> (ø)
gsa/src/gmp/commands/agents.js 30.43% <ø> (ø)
gsa/src/gmp/commands/alerts.js 14.28% <ø> (ø)
gsa/src/gmp/commands/audits.js 52.45% <ø> (ø)
gsa/src/gmp/commands/auth.js 100.00% <ø> (ø)
gsa/src/gmp/commands/certbund.js 63.63% <ø> (ø)
... and 323 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c51bbf...c7e2c97. Read the comment docs.

Add some more background for the reason of this code.
@swaterkamp swaterkamp merged commit c9dd20e into greenbone:gsa-9.0 Jul 2, 2020
@swaterkamp swaterkamp deleted the duplicateDashbSetting9 branch July 2, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants