Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spacing between radio buttons and inputs in override dialog #2286

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Fix spacing between radio buttons and inputs in override dialog #2286

merged 3 commits into from
Jul 2, 2020

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp requested review from sarahd93 and a team July 1, 2020 15:14
@swaterkamp swaterkamp self-assigned this Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020 •
edited
Loading

Codecov Report

Merging #2286 into gsa-20.08 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-20.08    #2286   +/-   ##
==========================================
  Coverage      52.76%   52.76%           
==========================================
  Files           1070     1070           
  Lines          25790    25790           
  Branches        7338     7311   -27     
==========================================
  Hits           13608    13608           
  Misses         11060    11060           
  Partials        1122     1122
Impacted Files Coverage Δ
gsa/src/web/pages/overrides/dialog.js 4.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d324cd...968abd5. Read the comment docs.

@bjoernricks bjoernricks merged commit 194690b into greenbone:gsa-20.08 Jul 2, 2020
@swaterkamp swaterkamp changed the title Severity in override dialog Fix spacing between radio buttons and inputs in override dialog Jul 2, 2020
@swaterkamp swaterkamp deleted the severityInOverrideDialog branch April 20, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahd93 sarahd93 sarahd93 approved these changes

Assignees

@swaterkamp swaterkamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swaterkamp @sarahd93 @bjoernricks