Add loading indicator for cves on cpe detailspage #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahd93
force-pushed
the
cpe_detailspage_loading_indicator
branch
from
a41701d to
aafcef7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2248 +/- ##
==========================================
- Coverage 52.74% 52.74% -0.01%
==========================================
Files 1070 1070
Lines 25777 25779 +2
Branches 7302 7304 +2
==========================================
Hits 13597 13597
- Misses 11058 11060 +2
Partials 1122 1122
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Jun 19, 2020
| @@ -136,8 +138,10 @@ const Details = ({entity, links = true}) => { | |||
| ))} | |||
| </TableBody> | |||
| </Table> | |||
| ) : ( | |||
| ) : cve_refs === 0 ? ( | |||
There was a problem hiding this comment.
I guess cve_refs is a count and not an array right?
There was a problem hiding this comment.
Right, cves is the array with all the cves in in it and cve_refs is the count. I totally missed that at first. cve_refs is also used for showing the number of cves on the listpage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: