Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form validation for CreateProcessDialog #2129

Merged
merged 7 commits into from
May 4, 2020

Conversation

swaterkamp
Copy link
Member

Checklist:

@swaterkamp swaterkamp self-assigned this Apr 30, 2020
@swaterkamp swaterkamp marked this pull request as ready for review April 30, 2020 14:57
@swaterkamp swaterkamp requested review from a team and sarahd93 April 30, 2020 14:57
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #2129 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2129      +/-   ##
==========================================
+ Coverage   52.67%   52.69%   +0.02%     
==========================================
  Files        1068     1069       +1     
  Lines       25654    25665      +11     
  Branches     7294     7296       +2     
==========================================
+ Hits        13513    13525      +12     
+ Misses      11027    11026       -1     
  Partials     1114     1114              
Impacted Files Coverage Δ
gsa/src/web/components/form/useFormValidation.js 100.00% <100.00%> (+2.63%) ⬆️
...c/web/components/processmap/createprocessdialog.js 100.00% <100.00%> (ø)
...a/src/web/components/processmap/validationrules.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a7d80...da27446. Read the comment docs.

@swaterkamp swaterkamp merged commit 117f40a into greenbone:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants