-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust task icons to work for audits and remove audit icons #2070
Merged
swaterkamp
merged 12 commits into
greenbone:master
from
sarahd93:remove_audit_icons_master
Mar 27, 2020
Merged
Adjust task icons to work for audits and remove audit icons #2070
swaterkamp
merged 12 commits into
greenbone:master
from
sarahd93:remove_audit_icons_master
Mar 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2070 +/- ##
==========================================
- Coverage 52.26% 52.23% -0.03%
==========================================
Files 1068 1066 -2
Lines 25528 25516 -12
Branches 7220 7244 +24
==========================================
- Hits 13341 13329 -12
Misses 11066 11066
Partials 1121 1121
Continue to review full report at Codecov.
|
sarahd93
force-pushed
the
remove_audit_icons_master
branch
from
March 27, 2020 07:32
3b73c3c
to
6837221
Compare
sarahd93
force-pushed
the
remove_audit_icons_master
branch
from
March 27, 2020 10:30
b9591e8
to
c5a875e
Compare
swaterkamp
reviewed
Mar 27, 2020
swaterkamp
reviewed
Mar 27, 2020
swaterkamp
reviewed
Mar 27, 2020
swaterkamp
reviewed
Mar 27, 2020
swaterkamp
reviewed
Mar 27, 2020
swaterkamp
reviewed
Mar 27, 2020
swaterkamp
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove audit icons and use task icons for both tasks and audits. This will reduce unnecessary duplicate code and fix problems with the audit icon tooltips.
Checklist: