Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust task icons to work for audits and remove audit icons #2070

Merged
merged 12 commits into from
Mar 27, 2020

Conversation

sarahd93
Copy link
Contributor

Remove audit icons and use task icons for both tasks and audits. This will reduce unnecessary duplicate code and fix problems with the audit icon tooltips.

Checklist:

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #2070 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2070      +/-   ##
==========================================
- Coverage   52.26%   52.23%   -0.03%     
==========================================
  Files        1068     1066       -2     
  Lines       25528    25516      -12     
  Branches     7220     7244      +24     
==========================================
- Hits        13341    13329      -12     
  Misses      11066    11066              
  Partials     1121     1121              
Impacted Files Coverage Δ
gsa/src/web/pages/audits/actions.js 100.00% <100.00%> (ø)
gsa/src/web/pages/audits/detailspage.js 100.00% <100.00%> (ø)
gsa/src/web/pages/tasks/icons/resumeicon.js 100.00% <100.00%> (ø)
gsa/src/web/pages/tasks/icons/starticon.js 100.00% <100.00%> (ø)
gsa/src/web/pages/tasks/icons/stopicon.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b602e9...3a4fc8f. Read the comment docs.

@sarahd93 sarahd93 force-pushed the remove_audit_icons_master branch from 3b73c3c to 6837221 Compare March 27, 2020 07:32
@sarahd93 sarahd93 force-pushed the remove_audit_icons_master branch from b9591e8 to c5a875e Compare March 27, 2020 10:30
@sarahd93 sarahd93 marked this pull request as ready for review March 27, 2020 10:40
@sarahd93 sarahd93 requested a review from a team March 27, 2020 10:40
@swaterkamp swaterkamp self-requested a review March 27, 2020 13:52
@swaterkamp swaterkamp merged commit b934132 into greenbone:master Mar 27, 2020
@sarahd93 sarahd93 deleted the remove_audit_icons_master branch March 27, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants