Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Report details hosts tab counts flickering #2023

Merged
merged 4 commits into from
Mar 9, 2020
Merged

Fix Report details hosts tab counts flickering #2023

merged 4 commits into from
Mar 9, 2020

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Mar 9, 2020 •
edited
Loading

Checklist:

@swaterkamp swaterkamp self-assigned this Mar 9, 2020
@swaterkamp swaterkamp marked this pull request as ready for review March 9, 2020 15:38
@swaterkamp swaterkamp requested a review from a team March 9, 2020 15:38
@codecov
Copy link

codecov bot commented Mar 9, 2020 •
edited
Loading

Codecov Report

Merging #2023 into gsa-9.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           gsa-9.0    #2023   +/-   ##
========================================
  Coverage    50.13%   50.13%           
========================================
  Files         1067     1067           
  Lines        25012    25012           
  Branches      7093     7067   -26     
========================================
  Hits         12540    12540           
  Misses       11335    11335           
  Partials      1137     1137
Impacted Files Coverage Δ
gsa/src/gmp/models/report/parser.js 97.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d69e1...4d8772d. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes Mar 9, 2020
View reviewed changes
@bjoernricks bjoernricks self-requested a review March 9, 2020 16:02
@swaterkamp swaterkamp merged commit 1afa1a6 into greenbone:gsa-9.0 Mar 9, 2020
@swaterkamp swaterkamp deleted the ReportDetailsHostsTabCounts branch April 20, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees

@swaterkamp swaterkamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swaterkamp @bjoernricks