Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance BPM #2018

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Advance BPM #2018

merged 5 commits into from
Mar 9, 2020

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Mar 9, 2020

This PR includes:

  • adding hostnames to host selection in ProcessPanel
  • error dialog when invalid characters are in ProcessName and hosts should be added
  • Fixing jumping processes when zoom and dragging are both appllied

Checklist:

@swaterkamp swaterkamp self-assigned this Mar 9, 2020
@swaterkamp swaterkamp marked this pull request as ready for review March 9, 2020 10:27
@swaterkamp swaterkamp requested review from a team and sarahd93 March 9, 2020 10:27
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #2018 into master will decrease coverage by 0.00%.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2018      +/-   ##
==========================================
- Coverage   52.04%   52.04%   -0.01%     
==========================================
  Files        1065     1065              
  Lines       25438    25449      +11     
  Branches     7193     7223      +30     
==========================================
+ Hits        13240    13245       +5     
- Misses      11076    11082       +6     
  Partials     1122     1122              
Impacted Files Coverage Δ
gsa/src/web/components/processmap/processpanel.js 89.43% <100.00%> (+0.35%) ⬆️
gsa/src/web/components/processmap/processmap.js 70.49% <22.22%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d854344...27a3e5f. Read the comment docs.

@swaterkamp swaterkamp changed the title Bpm lib Advance BPM Mar 9, 2020
@swaterkamp swaterkamp merged commit 8c5fea6 into greenbone:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants