Don't crash OsIcon when osCpe or osTxt are undefined

[swaterkamp]

Checklist:

• [N/A] Tests
• CHANGELOG Entry

[bjoernricks]

From the patch view I can't really see the cause of the issue but I guess real issue is below the changed code. What's the return value of OperatingSystems.find('') now?

[codecov]

Codecov Report

Merging #1975 into gsa-9.0 will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           gsa-9.0    #1975      +/-   ##
===========================================
- Coverage    49.02%   49.01%   -0.01%     
===========================================
  Files         1067     1067              
  Lines        24958    24960       +2     
  Branches      7026     7053      +27     
===========================================
  Hits         12235    12235              
- Misses       11564    11566       +2     
  Partials      1159     1159

Impacted Files	Coverage Δ
gsa/src/web/components/icon/osicon.js	56% <50%> (-4.87%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ddf90...6c861a8. Read the comment docs.

[swaterkamp]

It now returns undefined, if it receives an empty string as name-param. The issue was that it crashed when name was undefined and .include() couldn't be called at all.

The real issue definitely lies deeper and has been discussed across several teams in the last days. With this small fix we just take care that whenever this kind of situation comes up again, GSA doesn't crash and at least allows the user to continue work.

[bjoernricks]

Hmm after looking at the code and your changes again, I don't get how your PR fixes a problem. For me it doesn't really change the behavior.

[bjoernricks]

The only case were it could crash is if osTxt is defined and not a string. In that case neither the old nor the new code works.