Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct capabilities for task icons #1973

Merged
merged 7 commits into from
Feb 19, 2020

Conversation

sarahd93
Copy link
Contributor

The icons for start task, stop task and resume task were only checking if the user had permission to start/stop/resume tasks in general but not if he had permissions for that task in particular.

Checklist:

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #1973 into gsa-8.0 will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1973      +/-   ##
===========================================
+ Coverage    43.61%   43.71%   +0.10%     
===========================================
  Files          983      983              
  Lines        22824    22832       +8     
  Branches      6458     6465       +7     
===========================================
+ Hits          9954     9981      +27     
+ Misses       11665    11654      -11     
+ Partials      1205     1197       -8     
Impacted Files Coverage Δ
gsa/src/web/pages/tasks/icons/stopicon.js 100.00% <0.00%> (+60.00%) ⬆️
gsa/src/web/pages/tasks/icons/starticon.js 100.00% <0.00%> (+77.77%) ⬆️
gsa/src/web/pages/tasks/icons/resumeicon.js 100.00% <0.00%> (+81.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53fef23...1dbc0ce. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review February 19, 2020 08:24
@sarahd93 sarahd93 requested review from a team and swaterkamp February 19, 2020 08:24
@swaterkamp swaterkamp merged commit d8bbf41 into greenbone:gsa-8.0 Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants