Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing delete button for host identifiers #1959

Merged
merged 2 commits into from
Feb 4, 2020
Merged

fix missing delete button for host identifiers #1959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e6f68a
fix missing delete button for host identifiers
sarahd93 Feb 4, 2020
b0a18be
update changelog
sarahd93 Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Lower memory usage when getting a report [#1858](https://github.com/greenbone/gvmd/pull/1858)

### Fixed
- Fixed missing delete button for host identifiers [#1959](https://github.com/greenbone/gsa/pull/1959)
- Fixed sorting columns with empty string values [#1936](https://github.com/greenbone/gsa/pull/1936)
- Fixed broken entity links for reportformat, scanconfig and portlist [#1934](https://github.com/greenbone/gsa/pull/1934)
- Fixed removing levels filter keyword if all severity levels are unchecked [#1869](https://github.com/greenbone/gsa/pull/1869)
Expand Down
6 changes: 4 additions & 2 deletions gsa/src/web/pages/hosts/detailspage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,6 @@ const Page = ({
onHostDeleteClick={delete_func}
onHostDownloadClick={download}
onHostEditClick={edit}
onHostIdentifierDeleteClick={deleteidentifier}
>
{({activeTab = 0, onActivateTab}) => {
return (
Expand All @@ -319,7 +318,10 @@ const Page = ({
<Tabs active={activeTab}>
<TabPanels>
<TabPanel>
<Details entity={entity} />
<Details
entity={entity}
onHostIdentifierDeleteClick={deleteidentifier}
/>
</TabPanel>
<TabPanel>
<EntityTags
Expand Down