Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean-up-translations script #1948

Merged

Conversation

sarahd93
Copy link
Contributor

Add clean-up-translations script to remove empty strings from translations. This will ensure that the English text is used for strings that were not translated yet.

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review January 29, 2020 10:32
@sarahd93 sarahd93 requested a review from a team January 29, 2020 10:32
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicking

gsa/scripts/cleanuptranslations.js Outdated Show resolved Hide resolved
gsa/scripts/cleanuptranslations.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #1948 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
- Coverage   49.65%   49.64%   -0.02%     
==========================================
  Files        1043     1043              
  Lines       24672    24672              
  Branches     6974     7000      +26     
==========================================
- Hits        12252    12249       -3     
- Misses      11277    11280       +3     
  Partials     1143     1143
Impacted Files Coverage Δ
gsa/src/web/entities/container.js 44.67% <0%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693c704...315d0a2. Read the comment docs.

@bjoernricks bjoernricks merged commit e72b321 into greenbone:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants