Fix sorting by string values #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider undefined as an empty string when sorting strings instead of converting undefined to 'undefined'.
Update changelog for gsa-8 branch to use fixed consistently.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1936 +/- ##
========================================
Coverage 43.58% 43.58%
========================================
Files 983 983
Lines 22811 22811
Branches 6451 6476 +25
========================================
Hits 9943 9943
Misses 11663 11663
Partials 1205 1205
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider undefined as an empty string when sorting strings instead of
converting undefined to 'undefined'.
Checklist: