-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Business Process Maps #1931
Merged
Merged
Business Process Maps #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaterkamp
force-pushed
the
BPM-Lib
branch
2 times, most recently
from
January 19, 2020 15:37
effdb40
to
08dd8fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #1931 +/- ##
==========================================
+ Coverage 49.65% 50.59% +0.93%
==========================================
Files 1043 1065 +22
Lines 24672 25368 +696
Branches 6974 7171 +197
==========================================
+ Hits 12252 12835 +583
- Misses 11277 11384 +107
- Partials 1143 1149 +6
Continue to review full report at Codecov.
|
swaterkamp
force-pushed
the
BPM-Lib
branch
4 times, most recently
from
February 4, 2020 09:50
8c64f26
to
5fbcf00
Compare
swaterkamp
force-pushed
the
BPM-Lib
branch
8 times, most recently
from
February 12, 2020 08:56
4f95db8
to
f006a42
Compare
Also sort the routes
ConditionalColorizationIcon, NewProcessIcon, EdgeIcon Also change BpmIcon
PlusIcon, MinusIcon, MagnifierIcon
sarahd93
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main TODOs in no specific order:
[x] store individual processes in the store in order to load tagged hosts via process specific tag_ids
[x] actually load tagged hosts via tag_id filter
[x] since the whole map is loaded from the store, changing the map broke, which was possible for local state maps before. This needs to be adjusted
[x] color processes according to host severity and process connections
[x] zooming
[x] tests
[x] allow usage with initially empty usersetting
[x] saving changes of the map to the database (use saveBusinessProcessMaps())
[x] tag handling (creation, renaming, deletion)
Checklist: