Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Business Process Maps #1931

Merged
merged 87 commits into from
Feb 14, 2020
Merged

Business Process Maps #1931

merged 87 commits into from
Feb 14, 2020

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Jan 19, 2020

Main TODOs in no specific order:

[x] store individual processes in the store in order to load tagged hosts via process specific tag_ids
[x] actually load tagged hosts via tag_id filter
[x] since the whole map is loaded from the store, changing the map broke, which was possible for local state maps before. This needs to be adjusted
[x] color processes according to host severity and process connections
[x] zooming
[x] tests
[x] allow usage with initially empty usersetting
[x] saving changes of the map to the database (use saveBusinessProcessMaps())
[x] tag handling (creation, renaming, deletion)

Checklist:

@swaterkamp swaterkamp self-assigned this Jan 19, 2020
@swaterkamp swaterkamp force-pushed the BPM-Lib branch 2 times, most recently from effdb40 to 08dd8fa Compare January 19, 2020 15:37
@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

Merging #1931 into master will increase coverage by 0.93%.
The diff coverage is 80.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1931      +/-   ##
==========================================
+ Coverage   49.65%   50.59%   +0.93%     
==========================================
  Files        1043     1065      +22     
  Lines       24672    25368     +696     
  Branches     6974     7171     +197     
==========================================
+ Hits        12252    12835     +583     
- Misses      11277    11384     +107     
- Partials     1143     1149       +6
Impacted Files Coverage Δ
gsa/src/web/store/reducers.js 80% <ø> (ø) ⬆️
gsa/src/web/store/usersettings/actions.js 100% <ø> (ø) ⬆️
gsa/src/web/routes.js 83.33% <ø> (ø) ⬆️
gsa/src/web/components/link/externallink.js 91.3% <ø> (ø) ⬆️
gsa/src/web/store/usersettings/selectors.js 100% <ø> (ø) ⬆️
gsa/src/web/store/usersettings/reducers.js 100% <ø> (ø) ⬆️
gsa/src/web/pages/users/dialog.js 1.56% <ø> (ø) ⬆️
gsa/src/stories/confirmationdialog.js 0% <0%> (ø) ⬆️
gsa/src/web/store/businessprocessmaps/selectors.js 0% <0%> (ø)
gsa/src/web/components/bar/menubar.js 6.6% <0%> (-0.26%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38cd540...81ba089. Read the comment docs.

@swaterkamp swaterkamp force-pushed the BPM-Lib branch 4 times, most recently from 8c64f26 to 5fbcf00 Compare February 4, 2020 09:50
@swaterkamp swaterkamp force-pushed the BPM-Lib branch 8 times, most recently from 4f95db8 to f006a42 Compare February 12, 2020 08:56
@swaterkamp swaterkamp marked this pull request as ready for review February 13, 2020 16:38
@swaterkamp swaterkamp requested a review from a team February 13, 2020 16:38
@swaterkamp swaterkamp merged commit a41dfa1 into greenbone:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants