Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all uses of GMP COMMANDS #1896

Merged
merged 4 commits into from
Jan 3, 2020

Conversation

mattmundell
Copy link
Contributor

Requires greenbone/gvmd#923.

Checklist:

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #1896 into master will increase coverage by 1.14%.
The diff coverage is 41.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1896      +/-   ##
==========================================
+ Coverage   47.93%   49.08%   +1.14%     
==========================================
  Files        1036     1054      +18     
  Lines       24142    24829     +687     
  Branches     6809     7002     +193     
==========================================
+ Hits        11573    12187     +614     
- Misses      11429    11489      +60     
- Partials     1140     1153      +13
Impacted Files Coverage Δ
.../web/pages/reports/details/tlscertificatestable.js 25% <ø> (ø)
gsa/src/web/components/dialog/composercontent.js 66.66% <ø> (ø) ⬆️
gsa/src/web/pages/reports/details/reportpanel.js 37.5% <ø> (ø)
gsa/src/web/pages/reports/details/emptyreport.js 10% <ø> (ø)
...b/pages/reports/details/reportentitiescontainer.js 58.46% <ø> (ø)
...src/web/pages/reports/details/applicationstable.js 36.36% <ø> (ø)
gsa/src/web/pages/reports/details/alertactions.js 42.62% <ø> (ø)
...web/pages/reports/details/operatingsystemstable.js 36.36% <ø> (ø)
...rc/web/pages/reports/details/emptyresultsreport.js 15% <ø> (ø)
gsa/src/web/pages/results/listpage.js 50% <ø> (ø) ⬆️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b602305...dfa4b21. Read the comment docs.

@mattmundell mattmundell marked this pull request as ready for review January 3, 2020 09:25
@mattmundell mattmundell requested a review from a team January 3, 2020 09:25
@bjoernricks bjoernricks merged commit 58f042c into greenbone:master Jan 3, 2020
@mattmundell mattmundell deleted the remove-commands branch January 6, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants