Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed cve fixes #1850

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Closed cve fixes #1850

merged 3 commits into from
Dec 10, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Dec 10, 2019

Checklist:

Only list each closed cve once per host and use a unique id to fix
sorting at the reports details. A unique id is required as the key for
the closed cve list when it gets rendered as an array by react.
Use cveId from closed cves now.
@bjoernricks bjoernricks requested a review from a team December 10, 2019 16:29
@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #1850 into gsa-8.0 will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-8.0   #1850      +/-   ##
==========================================
- Coverage    40.12%   40.1%   -0.02%     
==========================================
  Files          975     975              
  Lines        22367   22374       +7     
  Branches      6289    6268      -21     
==========================================
  Hits          8974    8974              
- Misses       12118   12124       +6     
- Partials      1275    1276       +1
Impacted Files Coverage Δ
...a/src/web/pages/reports/details/closedcvestable.js 36.36% <0%> (ø) ⬆️
gsa/src/gmp/models/report/parser.js 75.09% <0%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6f625...b913605. Read the comment docs.

@bjoernricks bjoernricks merged commit 76841d8 into greenbone:gsa-8.0 Dec 10, 2019
@bjoernricks bjoernricks deleted the closed-cve-fixes branch December 10, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants