Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the length of result description with a div #1834

Merged
merged 4 commits into from
Dec 6, 2019

Conversation

saberlynx
Copy link
Contributor

Checklist:

@saberlynx saberlynx requested a review from a team December 5, 2019 12:16
bjoernricks
bjoernricks previously approved these changes Dec 5, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #1834 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsa-8.0   #1834      +/-   ##
==========================================
- Coverage     40.4%   40.4%   -0.01%     
==========================================
  Files          965     965              
  Lines        22133   22131       -2     
  Branches      6263    6262       -1     
==========================================
- Hits          8943    8941       -2     
  Misses       11937   11937              
  Partials      1253    1253
Impacted Files Coverage Δ
gsa/src/web/pages/results/details.js 8.51% <50%> (+1.98%) ⬆️
gsa/src/gmp/model.js 100% <0%> (ø) ⬆️
gsa/src/web/pages/permissions/dialog.js 6.12% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dac00b...32b6907. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes Dec 5, 2019
@bjoernricks
Copy link
Contributor

The changelog needs an update

@bjoernricks bjoernricks merged commit 800a454 into greenbone:gsa-8.0 Dec 6, 2019
@saberlynx saberlynx deleted the long-result-desc branch January 20, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants