Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New note dialog: make all fields editable when fixed #1817

Merged
merged 3 commits into from
Nov 28, 2019
Merged

New note dialog: make all fields editable when fixed #1817

merged 3 commits into from
Nov 28, 2019

Conversation

saberlynx
Copy link
Contributor

Checklist:

@saberlynx saberlynx marked this pull request as ready for review November 28, 2019 08:59
@saberlynx saberlynx requested a review from a team November 28, 2019 08:59
@codecov
Copy link

codecov bot commented Nov 28, 2019 •
edited
Loading

Codecov Report

Merging #1817 into gsa-8.0 will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1817      +/-   ##
===========================================
+ Coverage    40.02%   40.03%   +0.01%     
===========================================
  Files          965      965              
  Lines        22143    22136       -7     
  Branches      6244     6262      +18     
===========================================
  Hits          8863     8863              
+ Misses       12022    12015       -7     
  Partials      1258     1258
Impacted Files Coverage Δ
gsa/src/web/pages/notes/dialog.js 4.87% <0%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b7be1...48ea3be. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes Nov 28, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@bjoernricks bjoernricks self-requested a review November 28, 2019 09:51
@saberlynx @bjoernricks
Update CHANGELOG.md
48ea3be 
Co-Authored-By: Björn Ricks <[email protected]>
@bjoernricks bjoernricks merged commit 448a68f into greenbone:gsa-8.0 Nov 28, 2019
@saberlynx saberlynx deleted the notes-from-results branch January 20, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saberlynx @bjoernricks