Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override: Make host/port/task fields editable even when fixed, and display oid when no name is defined #1814

Merged
merged 3 commits into from
Nov 28, 2019
Merged

Override: Make host/port/task fields editable even when fixed, and display oid when no name is defined #1814

merged 3 commits into from
Nov 28, 2019

Conversation

saberlynx
Copy link
Contributor

Checklist:

@saberlynx saberlynx changed the base branch from master to gsa-8.0 November 27, 2019 14:32
@saberlynx saberlynx marked this pull request as ready for review November 27, 2019 14:35
@saberlynx saberlynx requested a review from a team November 27, 2019 14:35
@codecov
Copy link

codecov bot commented Nov 27, 2019 •
edited
Loading

Codecov Report

Merging #1814 into gsa-8.0 will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1814      +/-   ##
===========================================
+ Coverage    40.01%   40.02%   +0.01%     
===========================================
  Files          965      965              
  Lines        22150    22143       -7     
  Branches      6276     6244      -32     
===========================================
  Hits          8863     8863              
+ Misses       12029    12022       -7     
  Partials      1258     1258
Impacted Files Coverage Δ
gsa/src/web/utils/render.js 15.47% <0%> (ø) ⬆️
gsa/src/web/pages/overrides/dialog.js 4.08% <0%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e38ef7...9592bff. Read the comment docs.

@saberlynx saberlynx force-pushed the override-create branch 4 times, most recently from bac11cd to fdea7d1 Compare November 28, 2019 08:03
@saberlynx saberlynx changed the title Override: Show oid textfield when fixed but disable it Override: Make host/port/task fields editable even when fixed, and display oid when no name is defined Nov 28, 2019
@bjoernricks
Copy link
Contributor

Should fix #1807

@bjoernricks bjoernricks merged commit d4b7be1 into greenbone:gsa-8.0 Nov 28, 2019
@saberlynx saberlynx deleted the override-create branch January 20, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saberlynx @bjoernricks