Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing invalid override hosts #1810

Merged
merged 3 commits into from
Nov 26, 2019
Merged

Fix parsing invalid override hosts #1810

merged 3 commits into from
Nov 26, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Nov 26, 2019 •
edited
Loading

Checklist:

@bjoernricks
Don't crash if value for parseCvs is not as string
02a033c 
When using the parseCsv function in a model class it may be possible
that a non string value is passed. This happens e.g. with override hosts
containing a value like 123. Such values are converted to a number by
the fast-xml-parser automatically and did crash.
@bjoernricks
Don't crash if a non string value is passed to shorten function
8bbe17c
@bjoernricks bjoernricks changed the base branch from master to gsa-9.0 November 26, 2019 15:24
@bjoernricks bjoernricks marked this pull request as ready for review November 26, 2019 15:25
@codecov
Copy link

codecov bot commented Nov 26, 2019 •
edited
Loading

Codecov Report

Merging #1810 into gsa-9.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           gsa-9.0    #1810   +/-   ##
========================================
  Coverage    47.58%   47.58%           
========================================
  Files         1049     1049           
  Lines        24273    24273           
  Branches      6838     6811   -27     
========================================
  Hits         11551    11551           
  Misses       11572    11572           
  Partials      1150     1150
Impacted Files Coverage Δ
gsa/src/gmp/utils/string.js 100% <100%> (ø) ⬆️
gsa/src/gmp/parser.js 99.15% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0778908...3ecbae6. Read the comment docs.

@bjoernricks bjoernricks merged commit 03a99e3 into greenbone:gsa-9.0 Nov 26, 2019
@bjoernricks bjoernricks deleted the fix-parsing-invalid-override-hosts branch November 27, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahd93 sarahd93 sarahd93 approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @sarahd93