Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timezone in usermenu #1764

Merged
merged 13 commits into from
Nov 8, 2019
Merged

Timezone in usermenu #1764

merged 13 commits into from
Nov 8, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Nov 8, 2019 •
edited
Loading

Checklist:

@bjoernricks
Convert UserMenu into a function component
49ba5ff 
It doesn't need to be a class component.
@bjoernricks
Introduce useUserTimezone hook
5fa1aff 
Add our first simple custom hook to get the current users timezone from
the store.
@bjoernricks
Introduce useGmp hook
2b4b1cb 
Another very simple hook to provide the global gmp object.
@bjoernricks
Update DateTime component to use useUserTimezone hook
06e2047 
Without the connect function the DateTime component even looks much
cleaner and simpler to understand.
@bjoernricks
Display timezone for session timeout
4ba2f41 
Update user menu to display also the timezone in the session timeout.
@bjoernricks
Add changelog for session timeout timezone info
505d239
@bjoernricks
Update UserMenu to use useGmp instead of withGmp
6fb6a9e
@bjoernricks
Replace withRouter with useHistory in UserMenu
bc9119a 
With react router 5.1 we can use useParams, useLocation and useHistory.
@bjoernricks
Intoduce useUserName hook
63a58da 
Add a simple hook to get the current users name.
@bjoernricks
Update UserMenu to use useUserName hook
7d22fb9
@bjoernricks
Drop unnecessary proptype from UserMenuContainer
c981c7d
@bjoernricks
Introduce useUserSessionTimeout hook
79f25a2
@bjoernricks
Use useUserSessionTimeout in UserMenu
73b9f28 
This allows to simplify the UserMenu by dropping the proptypes, HOC
composition and store connection.
@bjoernricks bjoernricks marked this pull request as ready for review November 8, 2019 10:28
@swaterkamp
Copy link
Member

Love it!

@swaterkamp swaterkamp merged commit b94a306 into greenbone:gsa-9.0 Nov 8, 2019
@bjoernricks bjoernricks deleted the timezone-in-usermenu branch November 8, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoernricks @swaterkamp