[8.0] Reload on inactive tabs #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reloadIntervalActive and reloadIntervalInactive settings.
1. default reload interval -> used by default (15 seconds) 2. reload interval active -> used when an "active" process like scan is running (3 seconds) 3. reload interval inactive -> used when a page will "inactive" (60 seconds)
Add handlers for visibility changed events. If the current window/tab gets hidden the next reload interval will be "inactive" (60 seconds). If the window/tab gets activated again to current timer will be aborted and a new timer will be started. This new timer can be an active (3 seconds) or default (15 seconds) reload timer depending on the current page state.
Some of the behavior is tested only indirectly (e.g the exact used interval) because with class components it isn't possible to access and test internals.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1761 +/- ##
===========================================
+ Coverage 39.91% 39.98% +0.06%
===========================================
Files 965 965
Lines 22098 22134 +36
Branches 6254 6245 -9
===========================================
+ Hits 8821 8850 +29
- Misses 12020 12026 +6
- Partials 1257 1258 +1
Continue to review full report at Codecov.
|
swaterkamp
previously approved these changes
Nov 6, 2019
|
I'm not a 100% sure about the differing intervals of 3 and 5 seconds respectively. |
|
Currently the reload intervals are by default (via gmp settings):
let us discuss them before we merge the PR. |
removeVisibilityListender -> removeVisibilityListener Co-Authored-By: Steffen Waterkamp <[email protected]>
swaterkamp
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Reload component to consider hidden status of the current browser tab for calculating the reload interval.
Checklist: