if details not defined, then choose first OS from identifiers #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saberlynx
force-pushed
the
host-os-detail
branch
from
a11f0c4
to
4bf11ac
Compare
bjoernricks
suggested changes
Oct 24, 2019
|
Oh and it would be nice to write a test for this solution |
saberlynx
added
the
work in progress
saberlynx
force-pushed
the
host-os-detail
branch
5 times, most recently
from
e9eb503
to
8119a06
Compare
saberlynx
force-pushed
the
host-os-detail
branch
from
8119a06
to
83595c4
Compare
bjoernricks
approved these changes
Oct 24, 2019
saberlynx
removed
the
work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the host details are defined, it should still work as before.
Checklist: