Add loading indicator for select #1716
Conversation
There was a problem hiding this comment.
The isXyzLoading should be received from the redux store via mapStateToProps and selector.isLoadingEntities(filter) instead of the promise. Using the promise may show the wrong isLoading state because the promise resolved if we are already loading the entities at the moment but the response didn't arrive yet.
sarahd93
force-pushed
the
task_dialog_gsa9
branch
2 times, most recently
from
040f5ed to
1aeea24
Compare
There was a problem hiding this comment.
Sorry I did miss that last time, personally I would like to use isSomething for boolean properties. In that case it is obvious they expect true or false only. Hopefully I found all occurrences and changed loading to isLoading. Additionally the promise finally import should be obsolete now and a mapStateToProps function can be simplified. Despite being a number of changes this PR looks very good! Thanks a lot!
sarahd93
force-pushed
the
task_dialog_gsa9
branch
from
1aeea24 to
8863131
Compare
Checklist: